[
https://issues.apache.org/jira/browse/SOLR-18053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-18053:
-----------------------------
Description:
Currently it's unclear when to use the default solr.xm in tests and when you
want to have a configurable one. As [~dsmiley] noted in his second paragraph:
[https://github.com/apache/solr/pull/3988/files#r2654717093]
"Maybe that solr.xml should be in the solr-test-framework JAR as a resource
that the test infra can reference and be used by 3rd parties. But also need a
simple one-liner to install it into provided Path dir. Or alternatively a new
property to the node props which contains a path to where solr.xml "
This would be to investigate how Solr.xml is handled in tests and improve them.
A specific example is to compare core/src/test-files/solr/solr.xml against
solr/server/solr.xml and understand the settings. For example,
distribUpdateSoTimeout has a very short time out in the test version versus in
the shipped version.
Another though would be to figure out, do we need a seperate solr.xml for
tests, or, do we update our test rules to configure the solr.xml.. we might
find we can use a single solr.xml for both, and not configure things by copying
hardcoded xml files around... Also, I notice we use different configuration
names between the files. "hostPort" in test and "solr.port.advertise" in the
prod version.
was:
Currently it's unclear when to use the default solr.xm in tests and when you
want to have a configurable one. As [~dsmiley] noted in his second paragraph:
[https://github.com/apache/solr/pull/3988/files#r2654717093]
"Maybe that solr.xml should be in the solr-test-framework JAR as a resource
that the test infra can reference and be used by 3rd parties. But also need a
simple one-liner to install it into provided Path dir. Or alternatively a new
property to the node props which contains a path to where solr.xml "
This would be to investigate how Solr.xml is handled in tests and improve them.
> Have good solr.xml designed for testing
> ---------------------------------------
>
> Key: SOLR-18053
> URL: https://issues.apache.org/jira/browse/SOLR-18053
> Project: Solr
> Issue Type: Improvement
> Components: test-framework
> Reporter: Eric Pugh
> Priority: Major
>
> Currently it's unclear when to use the default solr.xm in tests and when you
> want to have a configurable one. As [~dsmiley] noted in his second
> paragraph: [https://github.com/apache/solr/pull/3988/files#r2654717093]
> "Maybe that solr.xml should be in the solr-test-framework JAR as a resource
> that the test infra can reference and be used by 3rd parties. But also need a
> simple one-liner to install it into provided Path dir. Or alternatively a new
> property to the node props which contains a path to where solr.xml "
>
> This would be to investigate how Solr.xml is handled in tests and improve
> them.
> A specific example is to compare core/src/test-files/solr/solr.xml against
> solr/server/solr.xml and understand the settings. For example,
> distribUpdateSoTimeout has a very short time out in the test version versus
> in the shipped version.
> Another though would be to figure out, do we need a seperate solr.xml for
> tests, or, do we update our test rules to configure the solr.xml.. we might
> find we can use a single solr.xml for both, and not configure things by
> copying hardcoded xml files around... Also, I notice we use different
> configuration names between the files. "hostPort" in test and
> "solr.port.advertise" in the prod version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
