dsmiley commented on PR #3995: URL: https://github.com/apache/solr/pull/3995#issuecomment-3707142887
I think changing this test isn't the way to go. What its doing isn't wrong. Doing so ignores a deeper root cause that likely affects other tests. We need to (somehow) start Solr with "urlScheme" configured on the HttpShardHandlerFactory in solr.xml, which the vast majority of tests use via their use of a test solr.xml that has it with var substitution. We could do so by having each test prep/configure/copy that solr.xml test fixture into place, which is what was happening before via SolrJettyTestBase, now removed. That would be a partial revert to this PR, in a sense -- we can certainly continue with the rule. But that's unsatisfying! Ideally this just gets set automatically if the circumstances are right. I'll post a PR today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
