gus-asf commented on PR #3997: URL: https://github.com/apache/solr/pull/3997#issuecomment-3707457442
> Gus, this was merged too quickly. Give a warning you are going to commit in a couple days if you have yet to receive a review. For one, I hate the name of this filter. Happy to revisit, but I can't really work on the next change without this one in place, and at the moment I have some time to put into this effort, and I want to take advantage of that time without making a monster PR... The goal of the name is to communicate/document that the things in this filter are key and required for solr, and that it's reasonable for code to rely on anything set up here (and not on things in other filters). Very open to suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
