dsmiley commented on PR #4009: URL: https://github.com/apache/solr/pull/4009#issuecomment-3717281065
I really appreciate the detailed inspection @malliaridis ! I am too dissatisfied with inexplicable inconsistencies to accept this as-is. Furthermore, this formatter is very slow. It takes a good deal longer than java and there's way more java. The Lucene project made it disable-able because of how slow it is. I think instead I'm simply going to have IntelliJ do a one-off reformat of all the gradle files, according to the rules we have in `.editorconfig` that I added some months back. I just did this right now and I'm not seeing inexplicable things at the spots you drew attention to. I'll do a new PR, as the approach is different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
