murblanc commented on code in PR #3851:
URL: https://github.com/apache/solr/pull/3851#discussion_r2671980911
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientCacheTest.java:
##########
@@ -109,7 +127,173 @@ public DocCollection get() {
UpdateRequest update = new UpdateRequest().add("id", "123", "desc",
"Something 0");
cloudClient.request(update, collName);
- assertEquals(2, refs.get(collName).getCount());
+ // Async refresh with deduplication means rapid retries can share the
same Future.
+ // Race: sometimes async completes fast enough for 2 fetches, sometimes
only 1.
Review Comment:
I don't get this.
The need to fetch again is the consequence of the first request having
failed, which implies a first fetch to know where to send that request.
So there is a dependency chain: `first fetch -> request -> failure -> second
fetch`
How can the two fetches be grouped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
