dsmiley commented on code in PR #4037:
URL: https://github.com/apache/solr/pull/4037#discussion_r2679929537
##########
gradle/hacks/global-exclude-dependencies.gradle:
##########
@@ -38,16 +38,19 @@ allprojects { prj ->
JavaPlugin.TEST_COMPILE_CLASSPATH_CONFIGURATION_NAME,
JavaPlugin.TEST_RUNTIME_CLASSPATH_CONFIGURATION_NAME
]
- configurations.matching { it.name in configNames }.all {
+ configurations.matching {it.name in configNames}.all {
exclude group: 'log4j', module: 'log4j' // use SLF4j
exclude group: "ch.qos.logback" // use SLF4j
exclude group: 'commons-logging', module: 'commons-logging' // use SLF4j
exclude group: 'com.google.code.findbugs', module: 'jsr305' // Uses GPL
license
- exclude group: 'com.google.code.findbugs', module: 'annotations' // Use
Spotbugs Annotations as replacement
- exclude group: 'javax.annotation', module: 'javax.annotation-api' //
Replaced with jakarta.annotation-api
+ exclude group: 'com.google.code.findbugs', module: 'annotations'
+ // Use Spotbugs Annotations as replacement
+ exclude group: 'javax.annotation', module: 'javax.annotation-api'
+ // Replaced with jakarta.annotation-api
exclude group: 'org.slf4j', module: 'slf4j-log4j12' // don't include log4j
1.x
exclude group: 'org.apache.yetus', module: 'audience-annotations' // Don't
need annotations
- exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
// Don't need annotations
+ exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
+ // Don't need annotations
Review Comment:
thanks; this very much needed correcting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
