epugh commented on code in PR #4042:
URL: https://github.com/apache/solr/pull/4042#discussion_r2680035220
##########
solr/core/src/test/org/apache/solr/spelling/suggest/TestPhraseSuggestions.java:
##########
@@ -17,19 +17,42 @@
package org.apache.solr.spelling.suggest;
import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.SolrTestCaseJ4Test;
+import org.apache.solr.SolrXPathTestCase;
+import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.common.params.SpellingParams;
+import org.apache.solr.util.EmbeddedSolrServerTestRule;
import org.junit.BeforeClass;
+import org.junit.ClassRule;
-public class TestPhraseSuggestions extends SolrTestCaseJ4 {
+public class TestPhraseSuggestions extends SolrXPathTestCase {
static final String URI = "/suggest_wfst";
+ @ClassRule
+ public static final EmbeddedSolrServerTestRule solrTestRule = new
EmbeddedSolrServerTestRule();
+
@BeforeClass
public static void beforeClass() throws Exception {
- initCore("solrconfig-phrasesuggest.xml", "schema-phrasesuggest.xml");
- assertQ(req("qt", URI, "q", "", SpellingParams.SPELLCHECK_BUILD, "true"));
Review Comment:
I had to move the assertQ into the public void test() because appparently
this is static and assertQ and req couldn't be called from a static method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
