rahulgoswami commented on code in PR #3903: URL: https://github.com/apache/solr/pull/3903#discussion_r2689103982
########## solr/core/src/java/org/apache/solr/handler/admin/api/UpgradeCoreIndex.java: ########## @@ -65,6 +65,34 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +/** + * Implements the UPGRADECOREINDEX CoreAdmin action, which upgrades an existing core's index Review Comment: I understand, and I did debate this. But eventually decided to be more verbose and spell out the high-level algorithm for anyone looking at the code. In my opinion, it might not hurt to keep certain implementation details in their current form in the javadoc(?). Edited to leave out certain details/notes more suitable for ref-guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
