jdyer1 opened a new pull request, #4050: URL: https://github.com/apache/solr/pull/4050
This adds `ConcurrentUpdateJdkSolrClient.java` and refactors the main unit tests to test both the Jetty and the JDK clients. Unlike with `LBAsyncSolrClient` and `CloudHttp2SolrClient`, this new client requires an `HttpJdkSolrClient` and not any subclass of `HttpSolrClientBase`. It did not seem possible to implement the abstract method `ConcurrentUpdateBaseSolrClient#doSendUpdateStream` without requiring the concrete client. Unlike with `ConcurrentUpdateJettySolrClient`, this implementation does not loop through the queue in `doSendUpdateStream` (the base class does this). I did not extend the tests `ConcurrentUpdateSolrClientBadInputTest` or `ConcurrentUpdateSolrClientMultiCollectionTest` to test this new client. These are testing the legacy client only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
