igiguere commented on code in PR #3829:
URL: https://github.com/apache/solr/pull/3829#discussion_r2696164988
##########
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java:
##########
@@ -699,7 +699,7 @@ public void test() throws Exception {
for (SolrClient client : clients) {
assertEquals(
"unexpected pre-commitWithin document count on node: "
- + ((HttpSolrClient) client).getBaseURL(),
+ + ((HttpApacheSolrClient) client).getBaseURL(),
Review Comment:
Here and elsewhere:
HttpApacheSolrClient is supposed to die, but all these tests now use it
instead of HttpSolrClient: the new one should be used.
IMHO, this looks weird, and it will all have to change eventually anyways
when HttpApacheSolrClient is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
