ilariapet opened a new pull request, #4056: URL: https://github.com/apache/solr/pull/4056
https://issues.apache.org/jira/browse/SOLR-17999 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Currently, the Text-to-Vector model store is initialised only when the corresponding LLM query parser is explicitly declared in `solrconfig.xml`. As a result, users who want to use text-to-vector models exclusively at index time (via an update request processor) cannot access the model store unless a query parser is also configured, even though all required indexing components are present. # Solution Ensure that the Text-to-Vector model store is also initialised when a text-to-vector update processor is configured. This enables the model store to be available for index-time usage independently of any query-time configuration. The documentation has been updated accordingly. # Tests Tests have been added to validate the initialisation behaviour of the Text-to-Vector model store across different `solrconfig.xml` configurations. They verify that the model store is correctly initialised when either the update processor or the query parser is configured, and that it is not registered otherwise, returning the expected error. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [X] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
