kotman12 commented on code in PR #4053:
URL: https://github.com/apache/solr/pull/4053#discussion_r2699834975


##########
solr/solr-ref-guide/modules/query-guide/pages/exporting-result-sets.adoc:
##########
@@ -44,6 +46,11 @@ Filter queries are also supported.
 An optional parameter `batchSize` determines the size of the internal buffers 
for partial results.
 The default value is `30000` but users may want to specify smaller values to 
limit the memory use (at the cost of degraded performance) or higher values to 
improve export performance (the relationship is not linear and larger values 
don't bring proportionally larger performance increases).
 
+An optional parameter `includeStoredFields` (default `false`) enables 
exporting fields that only have stored values (no docValues).

Review Comment:
   Actually, can I put the explanation in the CHANGELOG? The docs already warn:
   
   ```
   Note that retrieving stored fields may significantly impact export 
performance compared to docValues fields, as stored fields require additional 
I/O operations.
   ```



##########
solr/solr-ref-guide/modules/query-guide/pages/exporting-result-sets.adoc:
##########
@@ -44,6 +46,11 @@ Filter queries are also supported.
 An optional parameter `batchSize` determines the size of the internal buffers 
for partial results.
 The default value is `30000` but users may want to specify smaller values to 
limit the memory use (at the cost of degraded performance) or higher values to 
improve export performance (the relationship is not linear and larger values 
don't bring proportionally larger performance increases).
 
+An optional parameter `includeStoredFields` (default `false`) enables 
exporting fields that only have stored values (no docValues).

Review Comment:
   Actually, can I put the explanation in the CHANGELOG? The docs already warn:
   
   > Note that retrieving stored fields may significantly impact export 
performance compared to docValues fields, as stored fields require additional 
I/O operations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to