[
https://issues.apache.org/jira/browse/SOLR-18072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052492#comment-18052492
]
ASF subversion and git services commented on SOLR-18072:
--------------------------------------------------------
Commit b56803f278aa695717b829d12fe5356faf2c0444 in solr's branch
refs/heads/branch_10x from Houston Putman
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=b56803f278a ]
SOLR-18072: Refactor CollectionApiCommands to add expandable context (#4046)
(cherry picked from commit ec0c988fab94904e25f80524c30ce8eeb4107003)
> Refactor CollectionApiCommands to be able to easily pass in more context
> ------------------------------------------------------------------------
>
> Key: SOLR-18072
> URL: https://issues.apache.org/jira/browse/SOLR-18072
> Project: Solr
> Issue Type: Improvement
> Reporter: Houston Putman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Currently the method signature for these classes is:
> {{public void call(ClusterState state, ZkNodeProps message, NamedList<Object>
> results)}}
> There's not a lot of additional information that can be passed through. It
> would be great to eventually have these calls be typed instead of having
> generic ZkNodeProps messages (and when we move to exclusively use the v2 API
> this should be pretty easy to do). But in the meantime, trying to add
> information being sent to these commands is very hard because every single
> command needs to be updated.
> Instead if we pass in an {{AdminCmdContext}} that contains information
> relevant to the command request, then we can easily expand it in the future
> without having to refactor everything.
> {{public void call(AdminCmdContext context, ZkNodeProps message,
> NamedList<Object> results)}}
> In the first pass, the context would include things like {{operation}} and
> {{asyncId}} that are currently included in the ZkNodeProps, but are generic
> so can be formalized in the context class. It will also include the
> ClusterState, since that is what it is replacing in the method signature.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
