Copilot commented on code in PR #4064:
URL: https://github.com/apache/solr/pull/4064#discussion_r2705308384
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java:
##########
@@ -533,9 +563,10 @@ public UpdateResponse commit(
* @throws IOException If there is a low-level I/O error.
* @throws SolrServerException if there is an error on the server
*/
+ @Deprecated(since = "10.1")
public UpdateResponse commit(boolean waitFlush, boolean waitSearcher,
boolean softCommit)
throws SolrServerException, IOException {
- return commit(null, waitFlush, waitSearcher, softCommit);
+ return commit(null, CommitOptions.commit(softCommit).waitSearcher(true));
Review Comment:
The `waitSearcher` parameter is being ignored here. The method should use
`waitSearcher(waitSearcher)` instead of hardcoding `waitSearcher(true)` to
preserve backward compatibility with the deprecated method.
```suggestion
return commit(null,
CommitOptions.commit(softCommit).waitSearcher(waitSearcher));
```
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java:
##########
@@ -568,7 +599,26 @@ public UpdateResponse optimize(String collection) throws
SolrServerException, IO
* @throws SolrServerException if there is an error on the server
*/
public UpdateResponse optimize() throws SolrServerException, IOException {
- return optimize(null, true, true, 1);
+ return optimize(null, CommitOptions.optimize(1).waitSearcher(true));
+ }
+
+ /**
+ * Performs an explicit optimize, configured using {@link CommitOptions}
settings. *
Review Comment:
There's an extra asterisk in the javadoc. The line should start with just
one asterisk followed by the text, not two asterisks.
```suggestion
* Performs an explicit optimize, configured using {@link CommitOptions}
settings.
```
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CommitOptions.java:
##########
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.request;
+
+/**
+ * Encapsulates commit and optimize options for update requests. This class
provides a type-safe way
+ * to specify commit parameters instead of using multiple boolean parameters
in method signatures.
+ *
+ * @since Solr 10.0
+ */
+public class CommitOptions {
+
+ private boolean waitSearcher = true;
+ private boolean openSearcher = true;
+ private boolean softCommit = false;
+ private boolean expungeDeletes = false;
+ private int maxOptimizeSegments = Integer.MAX_VALUE;
+
+ /**
+ * Creates default commit options with: - waitSearcher: true - openSearcher:
true - softCommit:
+ * false - expungeDeletes: false - maxOptimizeSegments: Integer.MAX_VALUE
Review Comment:
The javadoc list format could be improved for readability. Consider using
proper list formatting such as:
<ul>
<li>waitSearcher: true</li>
<li>openSearcher: true</li>
<li>softCommit: false</li>
<li>expungeDeletes: false</li>
<li>maxOptimizeSegments: Integer.MAX_VALUE</li>
</ul>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
