dsmiley commented on code in PR #3891:
URL: https://github.com/apache/solr/pull/3891#discussion_r2717328261
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##########
@@ -681,6 +682,13 @@ protected Exception doRequest(
return ex;
}
+ protected boolean isConnectException(Throwable t) {
+ if (t instanceof ConnectException || t instanceof
HttpConnectTimeoutException) {
+ return true;
+ }
+ return t != null &&
t.getClass().getName().endsWith("ConnectTimeoutException");
Review Comment:
What is this designed to capture? (a comment would be helpful)
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java:
##########
@@ -681,6 +682,13 @@ protected Exception doRequest(
return ex;
}
+ protected boolean isConnectException(Throwable t) {
Review Comment:
I like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
