epugh commented on code in PR #4073:
URL: https://github.com/apache/solr/pull/4073#discussion_r2724151238
##########
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##########
@@ -735,8 +736,9 @@ protected void logAndFlushAdminRequest(SolrQueryResponse
solrResp) throws IOExce
solrResp.getToLogAsString("[admin]"));
}
}
+ // Admin requests have no core, use built-in writers
QueryResponseWriter respWriter =
-
SolrCore.DEFAULT_RESPONSE_WRITERS.get(solrReq.getParams().get(CommonParams.WT));
+
BuiltInResponseWriterRegistry.getWriter(solrReq.getParams().get(CommonParams.WT));
if (respWriter == null) respWriter = getResponseWriter();
Review Comment:
this is a fair comment. It's that werid "standard" thing. We should
either solve the null or delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
