Copilot commented on code in PR #811:
URL: https://github.com/apache/solr-operator/pull/811#discussion_r2729622401
##########
helm/solr/templates/solrcloud.yaml:
##########
@@ -146,6 +146,9 @@ spec:
{{- if .Values.dataStorage.persistent.pvc.storageClassName }}
storageClassName: {{
.Values.dataStorage.persistent.pvc.storageClassName | quote }}
{{- end }}
+ {{- if .Values.dataStorage.persistent.pvc.volumeAttributesClassName
}}
+ volumeAttributesClassName: {{
.Values.dataStorage.persistent.pvc.volumeAttributesClassName | quote }}
+ {{- end }}
Review Comment:
The volumeAttributesClassName field is being added inside a spec block that
is conditionally rendered (line 139). However, the condition on line 139 only
checks for capacity or storageClassName, not volumeAttributesClassName. This
means if a user sets only volumeAttributesClassName without setting either
storageClassName or capacity, the entire spec block will not be rendered, and
volumeAttributesClassName will be silently ignored. The condition on line 139
should be updated to include
.Values.dataStorage.persistent.pvc.volumeAttributesClassName in the 'or'
expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
