igiguere opened a new pull request, #4078: URL: https://github.com/apache/solr/pull/4078
https://issues.apache.org/jira/browse/SOLR-16458 # Jira Ticket The [Excel spreadsheet](https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?pli=1&gid=1579567767#gid=1579567767) links to SOLR-16458 for the V1 /solr/admin/info/system and V2 /api/node/system, although the ticket does not mention those URLs. From the checklist below : "I have created a Jira issue and added the issue ID to my pull request title." - m'well, no. But keeping track of these V2 tickets is probably difficult enough without # Description Implementation of a Jersey resource to support getting the system info. This new resource should replace the "@Endpoint" V2 resource. _DRAFT_: - Should we keep the URL path /node/system ? This PR suggests /node/info/system. If we keep the same URL path, then the "@Endpoint" will be deleted. - AdminHandlersProxy does not support V2, so this PR does not test parameter "nodes". Ref: PR #3991, mentioned in PR #4057 - TODO: Clean-up documentation. Path /admin/info/system is mentionned in 6 pages... And there's [SOLR-11918](https://issues.apache.org/jira/browse/SOLR-11918) ? # Solution Add NodeSystemInfoApi (in solr-api), implemented in GetNodeSystemInfo. Class NodeSystemInfoProvider contains code to provide the system info, copied from SystemInfoHandler. Clean-up SystemInfoHandler to use GetNodeSystemInfo. Adjust the response model NodeSystemInfoResponse to hold a map of node info. This is meant to replace the quick fix done in SolrJ in PR #3955. # Tests Add unit tests for NodeSystemInfoProvider (note that the test class for SystemInfoHandler was actually only testing a method now found in NodeSystemInfoProvider). Add unit tests for GetNodeSystemInfo. Functional tests on a local instance (dev-slim, started with the "cloud" example) # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
