epugh commented on PR #4073: URL: https://github.com/apache/solr/pull/4073#issuecomment-3811686023
> This PR lacks a JIRA reference. Since it did not, Jason was unable to get the bigger picture, and we end up with big picture discussions on a PR (something I think we want to avoid). Yeah, maybe could have been better organized. We had a chat on dev list, https://lists.apache.org/thread/82bj2l5b4s5rs9k45q9k2vf3o39t6bpg we also have https://issues.apache.org/jira/browse/SOLR-18079 and https://issues.apache.org/jira/browse/SOLR-18078 ^ that does sound a bit defensive, I know. It's all a bit of a mess. Do we think that for the purpose of this PR, if we just scope it to what is the title, _Separate core specific Request Writers from node specific "built in" ones. Move core specific to using ImplicitPlugins.json_ then would this be a PR that would be mergable? Or, do we need a fresh start? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
