janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r2737258681


##########
solr/core/src/test/org/apache/solr/cloud/TestEmbeddedZkQuorum.java:
##########


Review Comment:
   @epugh See last commit which adds two resilience tests to 
`TestEmbeddedZkQuorum`. 
   * `testQuorumResilienceWithNodeFailure` tests that we are operational when 
losing 1/3 nodes
   * `testQuorumLossAndRecovery` tests that we cannot create a collection when 
losing 2/3 nodes, and that it recovers back to quorum again
    
   I have not beasted them but pretty happy to see them pass in the first 
place. And as you probably guessed I did not write those tests, but Claude did 
and he needed some iterations, so there may absolutely be rough edges.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to