epugh commented on PR #4090: URL: https://github.com/apache/solr/pull/4090#issuecomment-3823782483
> I don't get the point of this PR. It removes 83 lines and adds 115. The code is not easier to read and does not solve any actual problem @epugh ? @janhoy I am looking back at the original JIRA issue, and not quite sure what looked odd to me about the use of static methods.. Maybe it was that some methods were not called by anyone at the time. Now, a few years later, and re-reading your comment on the JIRA issue, it looks like SOLR-16999 probably should have been closed after your comment about why the statics. Are you good then with me closing this PR and the related JIRA. @eshabakhov I really appreciate your contribution, and if you are interested in contributing more, here is a list of "newdev" related tickets: https://issues.apache.org/jira/browse/SOLR-18089?jql=project%20%3D%20SOLR%20AND%20status%20in%20(Open%2C%20Reopened%2C%20%22Patch%20Available%22)%20AND%20labels%20%3D%20newdev. I'll call out specifically https://issues.apache.org/jira/browse/SOLR-18089 which is a brand new one affecting Solr 10 and is a great one to learn more about Solr on. I guess the good thing about this PR is it caused a discussion and we can resolve the PR and JIRA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
