rahulgoswami commented on PR #3903: URL: https://github.com/apache/solr/pull/3903#issuecomment-3827869801
>>Do you think it'd be okay or weird/wrong if we move this method over there? Do you mean moving the toSolrInputDocument(Document,IndexSchema) method to RealTimeGetComponent ? I feel even the current method in RealTimeGetComponent doesn't *truly* belong there. It's a pure utility method independent of any class properties, and doesn't *have* to be private. I agree with maintaining these similar methods together. Would a util class like org.apache.solr.common.util.Utils be suitable for these methods? Rewiring RealTimeGetComponent would be fairly straightforward too since this method is private anyway. Unless you feel moving there would mean an increased possibility of them just being forgotten instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
