dsmiley commented on code in PR #4120:
URL: https://github.com/apache/solr/pull/4120#discussion_r2785894197
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -125,7 +118,7 @@ public void doFilter(HttpServletRequest request,
HttpServletResponse response, F
throws IOException, ServletException {
// internal version of doFilter that tracks if we are in a retry
- dispatch(chain, closeShield(request), closeShield(response), false);
+ dispatch(chain, request, response, false);
Review Comment:
I believe closeShield should be in SolrDispatchFilter (soon to be
SolrServlet) because this is the juncture at which there the request/response
escapes (into the massive Solr codebase) and we have no clear way to guarantee
that we don't close them. The filters beforehand are tidy components we can
reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
