malliaridis commented on code in PR #4127:
URL: https://github.com/apache/solr/pull/4127#discussion_r2795127607
##########
solr/bin/solr.cmd:
##########
@@ -399,6 +401,7 @@ IF "%1"=="-j" goto set_addl_jetty_config
IF "%1"=="--jettyconfig" goto set_addl_jetty_config
IF "%1"=="-y" goto set_noprompt
IF "%1"=="--no-prompt" goto set_noprompt
+IF "%1"=="--prompt" goto set_prompt
Review Comment:
Same here `--prompts`
##########
solr/bin/solr.cmd:
##########
@@ -341,8 +335,16 @@ goto err
@echo you could pass: -j
"--include-jetty-dir=/etc/jetty/custom/server/"
@echo In most cases, you should wrap the additional parameters
in double quotes.
@echo.
+@echo -e/--example name Name of the example to run; available examples:
+@echo cloud: SolrCloud example
+@echo techproducts: Comprehensive example illustrating many of Solr's
core capabilities
+@echo schemaless: Schema-less example (schema is inferred from data
during indexing)
+@echo films: Example of starting with _default configset and
defining explicit fields dynamically
+@echo.
@echo -y/--no-prompt Don't prompt for input; accept all defaults when
running examples that accept user input
@echo.
+@echo --prompt <values> Don't prompt for input; comma delimited list of
inputs read when running examples that accept user input."
Review Comment:
This should be probably `--prompts`
##########
solr/bin/solr:
##########
@@ -423,7 +417,15 @@ function print_usage() {
echo " you could pass: -j
\"--include-jetty-dir=/etc/jetty/custom/server/\""
echo " In most cases, you should wrap the
additional parameters in double quotes."
echo ""
- echo " -y/--no-prompt Don't prompt for input; accept all defaults
when running examples that accept user input"
+ echo " -e/--example <name> Name of the example to run; available
examples:"
+ echo " cloud: SolrCloud example"
+ echo " techproducts: Comprehensive example illustrating many of
Solr's core capabilities"
+ echo " schemaless: Schema-less example (schema is inferred
from data during indexing)"
+ echo " films: Example of starting with _default
configset and adding explicit fields dynamically"
+ echo ""
+ echo " -y/--no-prompt Don't prompt for input; accept all defaults
when running examples that accept user input."
+ echo ""
+ echo " --prompts <values> Don't prompt for input; comma delimited
list of inputs read when running examples that accept user input."
Review Comment:
This line seems malformed, the output is:
> -y/--no-prompt Don't prompt for input; accept all defaults when running
examples that accept user input
>
> The system cannot find the file specified.
>
> --verbose and -q/--quiet Verbose or quiet logging. Sets default log
level to DEBUG or WARN instead of INFO
It fails because of `<value>`, write it without the angle brackets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
