janhoy commented on code in PR #4054:
URL: https://github.com/apache/solr/pull/4054#discussion_r2798043572
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -388,6 +388,60 @@ def testChangelogMd(dir, version):
if 'v%s' % version not in content and version not in content:
raise RuntimeError('Version %s not found in CHANGELOG.md' % version)
+
+def testChangelogFolder(dir, version):
+ "Checks changelog folder structure."
+ changelog_folder = os.path.join(dir, 'changelog')
+
+ if not os.path.exists(changelog_folder):
+ raise RuntimeError('changelog folder not found at %s' % changelog_folder)
+
+ print(' check changelog folder structure...')
+
+ # Check that 'unreleased' folder exists and is empty
Review Comment:
Wizard may delete the `unreleased` folder right now, but that causes issues
with cerry-picks during backport. So I think the correct is to leave an empty
unreleased folder.
I think the reason I went with deleting the unreleased folder was for a more
"pretty" `-src.tgz` tarball for each release, which by definition has no
unreleased stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
