mlbiscoc commented on code in PR #4112:
URL: https://github.com/apache/solr/pull/4112#discussion_r2799082387
##########
solr/core/src/java/org/apache/solr/search/CollapsingQParserPlugin.java:
##########
@@ -223,46 +223,24 @@ public enum GroupHeadSelectorType {
MIN,
MAX,
SORT,
- SCORE;
+ SCORE,
+ CUSTOM;
Review Comment:
Maybe a point here that CUSTOM is specifically for subclasses? It's
currently not used anywhere including tests and someone may remove it by
mistake thinking no use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
