dsmiley commented on code in PR #4131:
URL: https://github.com/apache/solr/pull/4131#discussion_r2801996178
##########
solr/core/src/test/org/apache/solr/EchoParamsTest.java:
##########
@@ -40,17 +40,19 @@ public void test() {
// call them directly above:
private void defaultEchoParams() {
- lrf.args.put("wt", "xml");
+ // lrf.args.put("wt", "xml");
Review Comment:
`lrf.args` is a place to put defaults for the test. Kind of a test feature.
Shrug... if you remove it then you'll need to update tests that are populating
it. Even if args is removed, we can use `SolrParams.wrapDefaults` to ensure an
XML default format for the old TestHarness, which is likely necessary to avoid
touching many tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
