rahulgoswami commented on code in PR #4127:
URL: https://github.com/apache/solr/pull/4127#discussion_r2802704508
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -73,6 +73,16 @@ public class RunExampleTool extends ToolBase {
"Don't prompt for input; accept all defaults when running
examples that accept user input.")
.build();
+ private static final Option PROMPTS_OPTION =
+ Option.builder()
+ .longOpt("prompts")
+ .hasArg()
+ .argName("VALUES")
+ .desc(
+ "Provide comma-separated values for prompts. Same as --no-prompt
but uses provided values instead of defaults. "
+ + "Example: --prompts
3,8983,8984,8985,\"gettingstarted\",2,2,_default")
Review Comment:
Passing a formatted json in CLI could quickly get tricky with the quote
escaping etc, especially on Windows. I like the properties file idea. Somewhat
like we have for basic auth in solr.in.sh and solr.in.cmd with
"SOLR_AUTHENTICATION_OPTS"
(https://solr.apache.org/guide/solr/latest/deployment-guide/basic-authentication-plugin.html#using-the-solr-control-script-with-basic-auth).
It can take the actual credentials as well as path to a file.
I am ok if the properties file enhancement comes as a second wave (one can
hope!) and we could still use it against the same --prompts param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
