epugh opened a new pull request, #4147: URL: https://github.com/apache/solr/pull/4147
https://issues.apache.org/jira/browse/SOLR-15788 # Description Remove the use of legacyExampleCollection1SolrHome() in test setup in favour of our solrTestRule methods. # Solution Back in 2021 I opened https://github.com/apache/solr/pull/410 and it was one of my first attempts to make sense of how crazy the Solr code base was! It never landed because it just didn't seem better. Fastforward 5 years almost, and we have better ways of doing things. Turns our SolrTestRule's give us helpful builder methods that made it easy to remove this old legacy setup method. And simplified some tests too! # Tests Existing tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
