VishnuPriyaChandraSekar commented on code in PR #4162:
URL: https://github.com/apache/solr/pull/4162#discussion_r2850128898
##########
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/ZkClientClusterStateProvider.java:
##########
@@ -339,4 +339,16 @@ public int getZkClientTimeout() {
public void setZkClientTimeout(int zkClientTimeout) {
this.zkClientTimeout = zkClientTimeout;
}
+
+ /**
+ * @return url scheme with the help of cluster property or environment
variable.
+ */
+ @Override
+ public String getUrlScheme() {
+ Object urlSchemeClusterProperty =
getClusterProperty(ClusterState.URL_SCHEME);
+ if (urlSchemeClusterProperty != null) {
+ return urlSchemeClusterProperty.toString();
+ }
+ return Boolean.parseBoolean(System.getProperty(SOLR_SSL_ENABLED, "false"))
? "https" : "http";
Review Comment:
Should it return "http" if both cluster property and system property are not
set ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
