dsmiley commented on code in PR #4109:
URL: https://github.com/apache/solr/pull/4109#discussion_r2867529494
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java:
##########
@@ -26,30 +28,90 @@ public abstract class AbstractUpdateRequest extends
CollectionRequiringSolrReque
protected ModifiableSolrParams params = new ModifiableSolrParams(); // maybe
make final; no setter
protected int commitWithin = -1;
+ public AbstractUpdateRequest(METHOD m, String path) {
+ super(m, path, SolrRequestType.UPDATE);
+ }
+
+ public enum CommitOption {
+ /** Makes the changes visible. True by default. */
+ openSearcher,
+ /** The request should wait for the changes to be visible. True by
default. */
+ waitSearcher,
+ /** A faster commit that's slightly less durable, and only affects the
leader replica. */
+ softCommit;
+
+ /** Default standard set of commit options: waitSearcher and openSearcher
*/
+ public static final EnumSet<CommitOption> DEFAULTS =
EnumSet.of(waitSearcher, openSearcher);
Review Comment:
This constant is scoped inside the CommitOption, thus CommitOption.DEFAULTS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
