openworld-maker opened a new pull request, #4174: URL: https://github.com/apache/solr/pull/4174
This PR addresses [SOLR-18057](https://issues.apache.org/jira/browse/SOLR-18057) by eliminating unnecessary Path→String→Path conversions and using `Path.resolve(...)` when the base is already a Path (starting with BinaryFieldTest noted in the issue). No intended behavior change; refactor only. ## What changed - Refactored `TestBinaryField` to use `TEST_HOME().resolve("collection1").resolve("conf")` and `resolve(...)` for file paths. - Applied the same cleanup pattern in related tests where path bases were already `Path`: - `TestRawTransformer` - `TestCustomCoreProperties` - `TestCoreDiscovery` - `TestLazyCores` - `CoreAdminCreateDiscoverTest` - `CoreAdminHandlerTest` - `ReplicationTestHelper` - `TestSystemIdResolver` ## Validation - Focused tests passed: - `:solr:core:test --tests org.apache.solr.schema.TestBinaryField` - `:solr:core:test --tests org.apache.solr.util.TestSystemIdResolver` - `:solr:core:test --tests org.apache.solr.response.TestRawTransformer` - `:solr:core:test --tests org.apache.solr.TestCustomCoreProperties` - `./gradlew check` was attempted and hit unrelated environment/flaky issues (`CloudSolrClientCacheTest` flake and RAT task wiring check in this local environment). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
