anshumg commented on code in PR #4187: URL: https://github.com/apache/solr/pull/4187#discussion_r2884869325
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -240,15 +247,15 @@ The OS version of the official Docker image and provided Dockerfile has been upg === Miscellaneous -Solr logs no longer include webapp=/solr and there's no longer a "webapp" key-value pair in the internal context. +Solr logs no longer include `webapp=/solr` and there's no longer a `webapp` key-value pair in the internal context. === Analysis and Tokenizers ==== PathHierarchyTokenizer Behavior Change Due to Lucene 10 changes (https://github.com/apache/lucene/pull/12875), `PathHierarchyTokenizer` now produces sequential tokens (position increment = 1) instead of overlapping tokens (position increment = 0). This affects ancestor queries that relied on overlapping token matching. Users should test existing queries and update configurations if needed. -* In Lucene 10, the `OrdinalIterator` class has been moved from the main `lucene-facet` module to the `lucene-sandbox` module. This requires Solr core to now include a dependency on `lucene-sandbox` to support faceting operations that use this class. +In Lucene 10, the `OrdinalIterator` class has been moved from the main `lucene-facet` module to the `lucene-sandbox` module. This requires Solr core to now include a dependency on `lucene-sandbox` to support faceting operations that use this class. Review Comment: Do we need this level of implementation detail on this page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
