epugh commented on PR #4188: URL: https://github.com/apache/solr/pull/4188#issuecomment-4004935212
> Sound comments from Copilot, I believe all of them. > > Since this was a regression not caught by tests (since tests bootstrap the collection in a different way), perhaps change some test so that it fails without the fix, then we get increased test coverage and avoid future regressions. > Sound comments from Copilot, I believe all of them. > > Since this was a regression not caught by tests (since tests bootstrap the collection in a different way), perhaps change some test so that it fails without the fix, then we get increased test coverage and avoid future regressions. Since this is only on 9x, and I am not sure any of this moves to 10x, I'm not really feeling the "add test coverage and avoid future regressiosn".. I could of course regret this. Can we live with that and merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
