epugh opened a new pull request, #4204: URL: https://github.com/apache/solr/pull/4204
https://issues.apache.org/jira/browse/SOLR-18153 # Description uploading a file works, but due to how success/error is handled, you get a brower console error and therefore no visual feedback. # Solution The `.success()` and `.error()` methods on the `$http` promise were **deprecated in AngularJS 1.4** and **removed in AngularJS 1.6+**. Since the documents are still actually indexed (the POST itself succeeds), the underlying `$http.post()` works fine — it's only the callback wiring that was broken. # Tests Tested both positive and negative cases manually and I see the appropriate feedback. I also had claude check for OTHER situations like this, and this was the only one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
