HoustonPutman commented on code in PR #4069:
URL: https://github.com/apache/solr/pull/4069#discussion_r2933572934
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -1047,8 +1047,7 @@ public static String getShardLeadersElectPath(String
collection, String shardId)
+ (shardId != null ? ("/" + shardId + "/" + ELECTION_NODE) : "");
}
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection, String shardId, String thisCoreNodeName) {
+ public List<Replica> getReplicaProps(String collection, String shardId,
String thisCoreNodeName) {
Review Comment:
yeah, getReplicas is fine and the footprint isn't too big to include in this
PR. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
