epugh commented on PR #4217: URL: https://github.com/apache/solr/pull/4217#issuecomment-4067435319
> There's nothing "forbidden" here or wrong. It's simplification. The simpler it is, the easier to understand / maintain, and also the less barriers/issues if someone wants to try another SolrClientTestRule type. For example a SolrClientTestRule using docker wouldn't even have a "solr home". I think I'm not communciating well. It feels like there are too many ways of doing things, and most people don't really dig into the "what is the best way of doing something", instead we see a pattern and just copy and paste it. This may not be a good thing. So, maybe in the refacotring work I was doing, I got a pattern and jsut reused it. What I want is a way to keep our code clean over time, so that these types of refacotrings/usage conformance don't need to be constnatly redone over time as code changes. At any rate, this looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
