epugh commented on code in PR #4213:
URL: https://github.com/apache/solr/pull/4213#discussion_r2945759256
##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##########
@@ -93,7 +93,7 @@ public List<PlacementPlan> computePlacements(
}
List<WeightedNode> nodesForRequest =
-
weightedNodes.stream().filter(request::isTargetingNode).collect(Collectors.toList());
+ weightedNodes.stream().filter(request::isTargetingNode).toList();
Review Comment:
Claude looked at it and explained about the mutability thing... It's
interesting that nothing in the class speaks to mutablity which feels like a
trap. I mean, do I really need to think about mutability? It's like asking
me to think about memory management!!! What are we? C code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
