[
https://issues.apache.org/jira/browse/SOLR-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066471#comment-18066471
]
ASF subversion and git services commented on SOLR-18126:
--------------------------------------------------------
Commit aed1c3ef79add890c8be8e1652582ef494dc7045 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=aed1c3ef79a ]
SOLR-18126 Benchmark, refactor: MiniClusterState -> SolrBenchState (#4196)
Renames bench/MiniClusterState.java to bench/SolrBenchState.java, and flattens
its structure, which had an inner class. Two lifecycle methods containing
"miniCluster" in the name were replaced with "solr" to be generic, and I
improved javadocs slightly.
This is a preparatory refactoring step on a short journey to solr/benchmark
supporting multiple backends (not just MiniSolrCloudCluster).
Co-authored-by: Claude Opus 4.6 <[email protected]>
> Benchmarks: decouple from MiniSolrCloudCluster; support remote
> --------------------------------------------------------------
>
> Key: SOLR-18126
> URL: https://issues.apache.org/jira/browse/SOLR-18126
> Project: Solr
> Issue Type: Test
> Components: benchmarks
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently all JMH benchmarks in solr/benchmark are hard-wired to
> MiniSolrCloudCluster via MiniClusterState.MiniClusterBenchState. This makes
> it impossible to run benchmarks against a real Solr instance without code
> changes.
> Introduce a SolrBenchBackend interface with MiniClusterBackend (extracts
> existing mini-cluster logic) and RemoteSolrBackend (connects to an existing
> Solr via solr.bench.url system property) implementations. A new
> SolrBenchState JMH @State class replaces MiniClusterState, selecting the
> backend at runtime via a solr.bench.backend system property (minicluster by
> default).
> All existing benchmark classes (SimpleSearch, FilterCache, JsonFaceting,
> NumericSearch, QueryResponseWriters, ExitableDirectoryReaderSearch,
> StreamingSearch, CloudIndexing) are updated to use SolrBenchState. System
> properties previously set on benchmark setup that configure Solr internals
> (e.g. cache settings, merge policy) are converted to collection-level
> creation properties passed through createCollection, keeping them compatible
> with remote backends.
> MiniClusterState.java is deleted as part of this change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
