[ 
https://issues.apache.org/jira/browse/SOLR-18166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066480#comment-18066480
 ] 

Jason Gerlowski commented on SOLR-18166:
----------------------------------------

One question here is - should we remove "bin/solr zk linkconfig" from 
branch_10x as well as 'main'?  Or would doing so be a backcompat violation 
since the tool hasn't been properly deprecated?

The "letter of the law" would have us keep linkconfig around on branch_10x.  
But I'd argue that removing the tool is akin to fixing a bug.  At best the tool 
is misleading any users who might still use it today, as it is writing data to 
a location that Solr will never read from.  So while the "letter of the law" 
might argue to keep it around through 10.x, I don't think we'd be serving users 
in practice by doing so.  I'll opt to remove it from both 'main' and 
'branch_10x' unless anyone here objects?

> Remove outmoded "bin/solr zk linkconfig" subcommand and related code
> --------------------------------------------------------------------
>
>                 Key: SOLR-18166
>                 URL: https://issues.apache.org/jira/browse/SOLR-18166
>             Project: Solr
>          Issue Type: Bug
>          Components: scripts and tools
>    Affects Versions: main(11.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>
> SOLR-3460 added the "zkcli.sh" script that we shipped with Solr distributions 
> for many releases.  This tool contained a subcommand, "linkconfig", that 
> created a zkNode at the path "/collections/<someCollName>" whose 
> contents/data was essentially the configset name.
> This is something that made sense back in the 2012 timeframe when it was 
> added.  At that time most of the "Collection Admin" or collection CRUD APIs 
> we know and love today didn't exist.  So this manual "linking" process was a 
> required part of creating a new collection.
> But today this code is purely vestigial.  There are no usecases that would 
> have a user link a config today.  And no code in Solr looks for the 
> "configName" property at this outmoded location, excepting a few deprecated 
> methods that are slated for removal in or after Solr 10.
> I propose in this ticket that we:
> * remove "bin/solr zk linkconfig" (the linkconfig tooling was migrated here 
> when zkcli.sh was sunset as a part of SOLR-14115)
> * remove all of the methods and call-sites previously deprecated by 
> SOLR-14341 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to