gerlowskija commented on code in PR #4171:
URL: https://github.com/apache/solr/pull/4171#discussion_r2960685491
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/NodeHealthApi.java:
##########
@@ -30,5 +31,14 @@ public interface NodeHealthApi {
@Operation(
summary = "Determine the health of a Solr node.",
tags = {"node"})
- NodeHealthResponse healthcheck(@QueryParam("requireHealthyCores") Boolean
requireHealthyCores);
+ NodeHealthResponse healthcheck(
+ @QueryParam("requireHealthyCores") Boolean requireHealthyCores,
+ @Parameter(
+ description =
+ "Maximum number of index generations a follower replica may
lag behind its"
+ + " leader before the health check reports FAILURE. Only
relevant when"
+ + " running in legacy (non-SolrCloud) mode with
leader/follower"
Review Comment:
[0] I've seen you remove "legacy" a few other places based on an earlier
comment, but I think this one got missed.
I don't mind that language personally, but I don't think the community as a
whole agrees on that yet and there's probably some broader consensus-building
needed before we start calling leader/follower "legacy"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
