gerlowskija opened a new pull request, #4233: URL: https://github.com/apache/solr/pull/4233
https://issues.apache.org/jira/browse/SOLR-18163 # Description Solr has long supported an experimental sysprop `solr.api.v2.enabled` that can be used to disable the v2 API if set to false. This has been a nice safety-valve for users, but it prevents us from doing any dog-fooding of the v2 APIs since it makes it possible for the APIs to not be available at all. The v2 APIs are maturing and would really benefit from this additional testing and feedback. # Solution This commit removes the experimental system property and all references to v2 "optionality" in the codebase. # Tests Modifications to a BATS test meant to test our deprecation sysprop warnings. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
