epugh commented on PR #4227: URL: https://github.com/apache/solr/pull/4227#issuecomment-4109938907
I really like the upping of our game in validating things. I wish we had a more general way of handling lots of kinds of "integration" or "system" tests like this one. We have some emerging tests in our bats infrastructure, and then some of these smokTest things like this. Could this test have been based on a Docker based setup so that if I don't have a specific version of maven and gradle installed, that it would still work? It would be nice if running this was a constant thing, not a "and now it's release time" type thing. I also am not sure about more and more directories at the root.. Could `test-external-client` be part of some sort of `solr/system-tests`? Or `solr/smoke-tests`? With other heavy/complex tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
