gerlowskija opened a new pull request, #4239:
URL: https://github.com/apache/solr/pull/4239

   https://issues.apache.org/jira/browse/SOLR-13309
   
   # Description
   
   We have made changes recently to expose Lucene's `IntRange`, `LongRange`, 
and `FloatRange` field, but Solr still lacks coverage for `DoubleRange`.
   
   This PR adds the `DoubleRangeField` field type to expose `DoubleRange`.  
When merged, we'll have support for all of Lucene's "numeric range" field 
offerings!
   
   # Solution
   
   This PR takes a nearly identical approach to that seen recently in #4229, 
which introduced `FloatRangeField`.  The primary differences is that this PR 
uses 'double'/'Double' instead of 'float'/'Float', and that this PR is actually 
a good deal simpler as it's able to rely on groundwork already laid in the 
previous #4229.
   
   For those without context on 4229, the overview is that:
     - DoubleRangeField is new field type that extends 
AbstractNumericRangeField for most common plumbing.
     - Unit tests available in DoubleRangeFieldTest
     - Integration tests available in NumericRangeQParserPluginDoubleTest
     - Small documentation tweaks required in otherparsers.adoc and 
field-types-included-with-solr.adoc.
     
   Since this PR is so substantially similar to #4229, I was able to use Claude 
code to generate the tests and DoubleRangeField class.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   - [x] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [x] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to