dsmiley commented on code in PR #4186:
URL: https://github.com/apache/solr/pull/4186#discussion_r3005092134


##########
solr/core/src/test/org/apache/solr/cloud/DistribJoinFromCollectionTest.java:
##########
@@ -56,40 +55,50 @@ public class DistribJoinFromCollectionTest extends 
SolrCloudTestCase {
   //    resetExceptionIgnores();
   private static String toColl = "to_2x2";
   private static String fromColl = "from_1x4";
-
+  private static String configName = "solrCloudCollectionConfig";
   private static String toDocId;
+  private static JettySolrRunner coordinatorJetty;
+  private static Set<String> dataNodes;
 
   @BeforeClass
   public static void setupCluster() throws Exception {
     final Path configDir = TEST_COLL1_CONF();
 
-    String configName = "solrCloudCollectionConfig";
-    int nodeCount = 5;
+    // Create 4 data nodes
+    int nodeCount = 4;
     configureCluster(nodeCount).addConfig(configName, configDir).configure();
 
+    // Start a coordinator-only node (no data role)
+    System.setProperty(NodeRoles.NODE_ROLES_PROP, "coordinator:on,data:off");
+    try {
+      coordinatorJetty = cluster.startJettySolrRunner();
+    } finally {
+      System.clearProperty(NodeRoles.NODE_ROLES_PROP);

Review Comment:
   note: solr test infra detects all Sys prop changes and resets them between 
tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to