gerlowskija opened a new pull request, #4258: URL: https://github.com/apache/solr/pull/4258
https://issues.apache.org/jira/browse/SOLR-18121 # Description Prior to this commit, the IndexFetcher had support for an edge case where if a full-index-fetch was needed but the receiving host didn't have adequate disk space, then the IndexFetcher would delete the existing (out of date) copy of the index to free up space. Unfortunately, this optimization/"feature" was never documented in the ref-guide, had very little test coverage, and contained a number of resource-leaks that appeared to trigger 100% of the time. While the feature might've worked when initially written, the rare-ness of the triggering condition and lack of tests had led to some severe bitrot over time. # Solution This commit removes the code for this optimization altogether. It largely works by walking back the code introduced in the original change, 'b061947'. # Tests No new tests; removal of existing test `TestReplicationHandlerDiskOverFlow`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
