[
https://issues.apache.org/jira/browse/SOLR-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072639#comment-18072639
]
David Smiley commented on SOLR-18130:
-------------------------------------
Thanks for your first contribution here [~vyatkinv]! The builder connection
string thing will by itself be appreciated from my experience :-). I'll tend to
backports.
bq. It should work with my changes for both connection types now, but all the
variables and parameters are called zkHost. I propose adding a second
parameter, "connectionString," and considering the possibility of also
specifying zkHost to maintain backward compatibility.
Makes sense... maybe naming the parameter "solrcloud" will imply its use
plainly, especially when seen with its value. The name "connectionString" is
both long and seems overly generic in-context (this is SolrCloud specific).
Definitely need to retain "zkHost" for now. We can refer to this parameter
name as being deprecated in major-changes-in-solr-10.adoc & the ref guide
generally, updating usages to be "solrcloud".
> CloudSolrStream should not depend on ZooKeeper
> ----------------------------------------------
>
> Key: SOLR-18130
> URL: https://issues.apache.org/jira/browse/SOLR-18130
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ, streaming expressions
> Reporter: David Smiley
> Priority: Major
> Labels: newdev, pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> In the SolrJ streaming expressions module, CloudSolrStream depends on
> ZooKeeper, and thus so does its subclasses (DrillStream, TopicStream,
> ShuffleStream, ParallelStream). It's a runtime dependency, triggered by a
> "zkHost" parameter that's supplied to {{SolrClientCache#getCloudSolrClient}}
> that uses {{CloudSolrClient.Builder}} that uses reflection to try to load
> {{ZkClientClusterStateProvider}}.
> I propose renaming these parameters in the module from zkHost to maybe
> "quorumHosts" that could either be list of Solr HTTP (when it starts with
> "http:" or "https:") or ZK if not. This should bring about a new
> well-deserved constructor to CloudSolrClient.Builder to parse a string, as
> it's not a matter specific to streaming expressions. This would be very
> convenient to callers I've seen elsewhere.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
