r4mercur opened a new pull request, #4397: URL: https://github.com/apache/solr/pull/4397
https://issues.apache.org/jira/browse/SOLR-17715 Related pull requests before: https://github.com/apache/solr/pull/3441 For transparency i used claude code and github copilot for recommendations. <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Please provide a short description of the changes you're making with this pull request. # Solution Proposed solution changes in QueryRequest.java file. 1. getPath() override is removed 2. QueryRequest() no-argument sets /select as default to super() method 3. QueryRequests() with SolrParams and with Params and Method extract the qt in the constructor like recommended by dsmiley. 4. 2 new constructors with path and params & one with path, params and method. 5. two helper methods # Tests Test cases which are added: in class QueryRequestTest.java 1. testQtWithSlashBecomesPath: qt=/custom no qt in params 2. testQtWithoutSlashDefaultsToSelect: qt=custom no path = /select path 3. testDefaultPathToSelect: no qt param = default path /select # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
