adityamparikh opened a new pull request, #129:
URL: https://github.com/apache/solr-mcp/pull/129

   ## Summary
   - Remove `@DisabledInNativeImage` from `IndexingServiceIntegrationTest` and 
`SearchServiceIntegrationTest` so they run under `nativeTest`. These tests use 
real Solr via Testcontainers and have no fundamental incompatibility with the 
native image runtime — they were marked disabled defensively when GraalVM 
support was added, but the actual native-image blocker is Mockito (ByteBuddy), 
which these integration tests don't use.
   - Add `--initialize-at-build-time` entries for 
`org.junit.platform.launcher`, `org.junit.platform.engine`, and 
`org.junit.jupiter.engine.descriptor` in `build.gradle.kts` so the test binary 
can be built with these tests included. Without these, `nativeTest` fails with 
`An object of type 'org.junit.platform.engine.TestTag' was found in the image 
heap. This type, however, is marked for initialization at image run time` 
because the GraalVM JUnit launcher embeds test discovery results (TestPlan, 
descriptors, TestTag) at build time.
   
   ## Why this matters
   Today the Testcontainers integration tests are JVM-only by annotation, and 
`nativeTest` therefore covers only collection/schema/MCP-protocol paths. After 
this change, the same end-to-end indexing and search behaviour we verify on JVM 
is verified against the native binary too — closing the largest 
functional-coverage gap between the two runtimes.
   
   `@DisabledInNativeImage` remains on the truly incompatible Mockito-based 
unit tests (`CollectionServiceTest`, `IndexingServiceTest`, 
`SchemaServiceTest`, `SearchServiceTest`, `MainTest`).
   
   ## Test plan
   - [x] `./gradlew compileTestJava` — passes
   - [x] `./gradlew spotlessCheck` — passes
   - [ ] `./gradlew nativeTest -Pnative` — needs CI verification (long 
native-image build, not run locally)
   - [ ] CI nativeTest job covers indexing + search integration paths against 
the native binary
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to