dsmiley commented on code in PR #4370: URL: https://github.com/apache/solr/pull/4370#discussion_r3206257431
########## changelog/unreleased/PR#4370-use-own-object-mapper-for-v2api.yml: ########## Review Comment: Wether there's a JIRA or not doesn't matter, although it tends to be correlated as something not changelog worthy isn't JIRA-worthy either... although we sometimes create JIRAs to remember to do something which is quite alright. The way I think of a writing a changelog entry is, I think, rather simple. Step back from the nitty gritty details of the PR and imagine telling a a stranger who uses Solr about what you did in a way that hopefully might interest them. The changelog speaks to the user -- it's a summary that many users read each release. _How is this change making Solr better?_ If it's too much of a stretch to write something of interest then don't bother wasting both your time and more importantly all potential readers of it. The "Other" section can be an exception to this as it's more open up to Solr hackers to record more significant changes that won't interest users. Changes significant enough that us Solr hackers (Solr plugin authors & Solr contributors) may want to remember that a notable thing happened in this Solr version, like a significant (not insignificant) refactoring. And no-changelog doesn't mean a PR isn't appreciated! > What you think of the fix itself, is this a fix or improvement in your opinion? All I could discern of interest is the support for comments. I'm unsure if this was possible before? Seems too minor to mention IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
